Repository navigation
Map settlement state 9 (SETTLED_NEEDS_BATCH_PROCESSING) to CLEARED - #87798
Conversation
|
No new product considerations - removing my assignment and unsubscribing. |
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No QA needed for this one |
|
No help site changes required. This PR adds an internal settlement state mapping (state 9 →
None of these articles document specific settlement state numbers or status badge labels. They describe the reconciliation workflow at a higher level (viewing withdrawals, matching to expenses, verifying totals). Since no new UI, features, or user-facing workflows are introduced, no docs updates are needed. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
Adds reimbursement state 9 (
SETTLED_NEEDS_BATCH_PROCESSING) to thesettlementStatusMapin the search UI, mapping it toCLEARED. This state represents settlements that succeeded but still need batch processing (e.g. wallet payments). Previously, state 9 defaulted toPENDINGwhich was incorrect, the payment has already settled.This is the frontend counterpart to the Auth PR that expands
RECONCILIATION_REIMBURSEMENT_STATESto include state 9, so these settlements now appear in New Dot's reconciliation search results.Fixed Issues
https://github.com/Expensify/Expensify/issues/604799
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.